Skip to content

Commit

Permalink
Automated rollback of commit 8ef7b70.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

The experiment with using sqlite didn't pan out. We might find other uses for it in the future, but we can always resurrect it from version control; no need to saddle Bazel with the additional dependency until then.

*** Original change description ***

Implement a JNI wrapper around SQLite.

This will be used by the implementation of garbage collection for the disk cache, as discussed in #5139 and the linked design doc. I judge this to be preferred over https://github.com/xerial/sqlite-jdbc for the following reasons:

1. It's a much smaller dependency.
2. The JDBC API is too generic and becomes awkward to use when dealing with the peculiarities of SQLite.
3. We can (more easily) compile it from source for all host platforms, including the BSDs.

***

PiperOrigin-RevId: 679600756
Change-Id: Ic3748fa30404a31504426c523c9b9a60ec451863
  • Loading branch information
tjgq authored and copybara-github committed Sep 27, 2024
1 parent db4a400 commit e8c5fb3
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 1,060 deletions.
1 change: 0 additions & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ bazel_dep(name = "rules_pkg", version = "0.9.1")
bazel_dep(name = "stardoc", version = "0.7.1", repo_name = "io_bazel_skydoc")
bazel_dep(name = "zstd-jni", version = "1.5.2-3.bcr.1")
bazel_dep(name = "blake3", version = "1.5.1.bcr.1")
bazel_dep(name = "sqlite3", version = "3.42.0.bcr.1")
bazel_dep(name = "zlib", version = "1.3.1.bcr.3")
bazel_dep(name = "rules_cc", version = "0.0.10")
bazel_dep(name = "rules_java", version = "7.11.1")
Expand Down
2 changes: 0 additions & 2 deletions MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ DIST_ARCHIVE_REPOS = [get_canonical_repo_name(repo) for repo in [
"rules_pkg",
"rules_proto",
"rules_python",
"sqlite3",
"upb",
"zlib",
"zstd-jni",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ java_library(
srcs = glob(["*.java"]),
deps = [
"//src/main/java/com/google/devtools/build/lib/concurrent",
"//src/main/java/com/google/devtools/build/lib/jni",
"//src/main/java/com/google/devtools/build/lib/remote:store",
"//src/main/java/com/google/devtools/build/lib/remote/common",
"//src/main/java/com/google/devtools/build/lib/remote/common:cache_not_found_exception",
Expand Down
Loading

0 comments on commit e8c5fb3

Please sign in to comment.