Skip to content

Commit

Permalink
Automatic code cleanup.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 529653758
Change-Id: Iea7197c3251a87f91205948637bf9e0cea25f18a
  • Loading branch information
Googler authored and copybara-github committed May 5, 2023
1 parent 5226e3b commit c72643c
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 46 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ public enum ArtifactCategory {
this.starlarkName = toString().toLowerCase();
}

public String getStarlarkName() {
return starlarkName;
}

/** Returns the name of the category. */
public String getCategoryName() {
return this.toString().toLowerCase();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,6 @@ private CcCompilationOutputs(
this.headerTokenFiles = headerTokenFiles;
}

/**
* Returns whether this set of outputs has any object or .pic object files.
*/
public boolean isEmpty() {
return picObjectFiles.isEmpty() && objectFiles.isEmpty();
}

/**
* Returns an unmodifiable view of the .o or .pic.o files set.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -303,12 +303,6 @@ public static class Builder {
private final ImmutableList.Builder<Artifact> nonCodeInputs = ImmutableList.builder();
private final ImmutableList.Builder<Linkstamp> linkstamps = ImmutableList.builder();

@CanIgnoreReturnValue
public Builder addLibrary(LibraryToLink library) {
this.libraries.add(library);
return this;
}

@CanIgnoreReturnValue
public Builder addLibraries(List<LibraryToLink> libraries) {
this.libraries.addAll(libraries);
Expand Down Expand Up @@ -557,13 +551,6 @@ public Builder setOwner(Label owner) {
return this;
}

@CanIgnoreReturnValue
public Builder addLibrary(LibraryToLink library) {
hasDirectLinkerInput = true;
linkerInputBuilder.addLibrary(library);
return this;
}

@CanIgnoreReturnValue
public Builder addLibraries(List<LibraryToLink> libraries) {
hasDirectLinkerInput = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@

package com.google.devtools.build.lib.rules.cpp;

import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSetMultimap;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.starlarkbuildapi.cpp.CcLinkingOutputsApi;
import com.google.devtools.build.lib.vfs.FileSystemUtils;
Expand Down Expand Up @@ -73,21 +71,6 @@ public boolean isEmpty() {
return libraryToLink == null;
}

/**
* Gathers up a map from library identifiers to sets of LibraryToLink which share that library
* identifier.
*/
public static ImmutableSetMultimap<String, LinkerInputs.LibraryToLink> getLibrariesByIdentifier(
Iterable<LinkerInputs.LibraryToLink> inputs) {
ImmutableSetMultimap.Builder<String, LinkerInputs.LibraryToLink> result =
new ImmutableSetMultimap.Builder<>();
for (LinkerInputs.LibraryToLink library : inputs) {
Preconditions.checkNotNull(library.getLibraryIdentifier());
result.put(library.getLibraryIdentifier(), library);
}
return result.build();
}

private static final ImmutableList<String> PIC_SUFFIXES =
ImmutableList.of(".pic.a", ".nopic.a", ".pic.lo");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,6 @@ public ImmutableList<StringChunk> getChunks() {
return chunks.build();
}

/** @return all variable names needed to expand this string. */
ImmutableSet<String> getUsedVariables() {
return usedVariables.build();
}

/**
* Parses the string.
*
Expand Down

0 comments on commit c72643c

Please sign in to comment.