Skip to content

Commit

Permalink
Automated rollback of commit bc1e9d8.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

Probable culprit for b/252758923 Autopush for pod-batch flumes failing with CLIENT_VIOLATES_BUILD_HORIZON

*** Original change description ***

Rollforward of e96507b: Enable Starlark java_binary

PiperOrigin-RevId: 480480926
Change-Id: Ib53d56f08c4442aa93b1013283b4d69e218c09c6
  • Loading branch information
comius authored and copybara-github committed Oct 11, 2022
1 parent 1ab8498 commit c5ccb06
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ protected void useConfiguration(ImmutableMap<String, Object> starlarkOptions, St
ImmutableList.Builder<String> fullArgs = ImmutableList.builder();
fullArgs.add("--incompatible_enable_android_toolchain_resolution");
// Uncomment the below to get more info when tests fail because of toolchain resolution.
// fullArgs.add("--toolchain_resolution_debug=tools/android:.*toolchain_type");
// fullArgs.add("--toolchain_resolution_debug=tools/android:.*toolchain_type");
boolean hasPlatform = false;
for (String arg : args) {
if (arg.startsWith("--android_sdk=")) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1615,14 +1615,12 @@ public void starlarkJavaToJavaBinaryAttributes() throws Exception {
" deps = [':mya'], runtime_deps = [':myb'])");
assertNoEvents();

setBuildLanguageOptions("--experimental_google_legacy_api");
// Test that all bottom jars are on the runtime classpath.
ConfiguredTarget binary = getConfiguredTarget("//foo:binary");
assertThat(
prettyArtifactNames(
binary
.get(JavaInfo.PROVIDER)
.getCompilationInfoProvider()
.getProvider(JavaRuntimeClasspathProvider.class)
.getRuntimeClasspath()
.getSet(Artifact.class)))
.containsAtLeast("foo/libjl_bottom_for_deps.jar", "foo/libjl_bottom_for_runtime_deps.jar");
Expand Down Expand Up @@ -1973,7 +1971,6 @@ public void javaBinary_propagatesDirectNativeLibrariesInJavaInfo() throws Except
"my_rule(name = 'r', dep = ':jl', cc_dep = ':ccl')",
"java_binary(name = 'binary', main_class = 'C', srcs = ['java/C.java'], deps = [':r'])");

setBuildLanguageOptions("--experimental_google_legacy_api");
ConfiguredTarget testTarget = getConfiguredTarget("//foo:binary");

TemplateExpansionAction action =
Expand Down Expand Up @@ -2221,7 +2218,6 @@ public void javaCommonCompileNeverlink() throws Exception {
" fragments = ['java']",
")");

setBuildLanguageOptions("--experimental_google_legacy_api");
ConfiguredTarget target = getConfiguredTarget("//java/test:plugin");
assertThat(
actionsTestUtil()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ public void splitDeps() throws Exception {
"java/a/BUILD",
"cc_library(name = 'lib', srcs = ['lib.cc'])",
"android_binary(name='a', manifest = 'AndroidManifest.xml', deps = [':lib'])");
useConfiguration("--fat_apk_cpu=k8,armeabi-v7a", "--experimental_google_legacy_api");
useConfiguration("--fat_apk_cpu=k8,armeabi-v7a");
List<ConfiguredTarget> deps = getConfiguredDeps("//java/a:a", "deps");
assertThat(deps).hasSize(2);
ConfiguredTarget dep1 = deps.get(0);
Expand Down

0 comments on commit c5ccb06

Please sign in to comment.