Fix network sandboxing on macOS.

Fixes #10068. RELNOTES: None. PiperOrigin-RevId: 279958764
bazelbuild · Nov 12, 2019 · 8e7c349 · 8e7c349
1 parent ac04cd9
commit 8e7c349
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/sandbox/DarwinSandboxedSpawnRunner.java b/src/main/java/com/google/devtools/build/lib/sandbox/DarwinSandboxedSpawnRunner.java
@@ -340,7 +340,6 @@ private void writeConfig(
 
       if (!allowNetwork) {
         out.println("(deny network*)");
-        out.println("(allow network* (local ip \"localhost:*\"))");
         out.println("(allow network* (remote ip \"localhost:*\"))");
         out.println("(allow network* (remote unix-socket))");
       }

diff --git a/src/test/shell/bazel/bazel_sandboxing_test.sh b/src/test/shell/bazel/bazel_sandboxing_test.sh
@@ -379,12 +379,6 @@ genrule(
 )
 EOF
 
-  # TODO(https://github.com/bazelbuild/bazel/issues/10068): Remove once
-  # network sandboxing works on macOS.
-  case "$(uname -s)" in
-    Darwin) REMOTE_NETWORK_ADDRESS= ;;
-  esac
-
   if [[ -n "${REMOTE_NETWORK_ADDRESS}" ]]; then
     local hostname="${REMOTE_NETWORK_ADDRESS%:*}"
     local remote_ip