Skip to content

Commit

Permalink
remote: limit number of open tcp connections by default. Fixes #5491
Browse files Browse the repository at this point in the history
This change limits the number of open tcp connections
by default to 100 for remote caching. We have had error
reports where some use cases Bazel would open so many
TCP connections that it crashed/ran out of sockets. The
max. number of TCP connections can still be adjusted by
specifying --remote_max_connections.

See also #5047.

RELNOTES: In remote caching we limit the number of open
TCP connections to 100 by default. The number can be adjusted
by specifying the --remote_max_connections flag.
PiperOrigin-RevId: 202958838
  • Loading branch information
buchgr authored and Chris Parsons committed Jul 9, 2018
1 parent 9dabbb1 commit 7e5e4c3
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,13 @@ public final class RemoteOptions extends OptionsBase {

@Option(
name = "remote_max_connections",
defaultValue = "0",
defaultValue = "100",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.HOST_MACHINE_RESOURCE_OPTIMIZATIONS},
help =
"The max. number of concurrent network connections to the remote cache/executor. By "
+ "default Bazel selects the ideal number of connections automatically.")
+ "default Bazel limits the number of TCP connections to 100. Setting this flag to "
+ "0 will make Bazel choose the number of connections automatically.")
public int remoteMaxConnections;

@Option(
Expand Down

0 comments on commit 7e5e4c3

Please sign in to comment.