Skip to content

Commit

Permalink
Update tests to avoid --noexperimental_ui
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 247221631
  • Loading branch information
ulfjack authored and copybara-github committed May 8, 2019
1 parent 2affaeb commit 7b7a09f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 11 deletions.
3 changes: 1 addition & 2 deletions src/test/shell/integration/client_sigint_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ EOF
mkfifo $testfifo $sleepyfifo || fail "Couldn't create FIFOs under x"

set -m
# TODO(b/37617303): make test UI-independent
bazel $startup_opt build --noexperimental_ui \
bazel $startup_opt build --experimental_ui_debug_all_events \
--package_path . //x:sleepy >& $TEST_log &
local pid=$!

Expand Down
6 changes: 3 additions & 3 deletions src/test/shell/integration/discard_analysis_cache_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,18 @@ EOF

function test_compile_helloworld() {
write_hello_world_files
bazel run --noexperimental_ui --discard_analysis_cache hello:hello >&$TEST_log \
bazel run --experimental_ui_debug_all_events --discard_analysis_cache hello:hello >&$TEST_log \
|| fail "Build failed"
expect_log "Loading package: hello"
expect_log 'hello!'

bazel run --noexperimental_ui --discard_analysis_cache hello:hello >&$TEST_log \
bazel run --experimental_ui_debug_all_events --discard_analysis_cache hello:hello >&$TEST_log \
|| fail "Build failed"
expect_not_log "Loading package: hello"
expect_log 'hello!'

# Check that further incremental builds work fine.
bazel run --noexperimental_ui hello:hello >&$TEST_log \
bazel run --experimental_ui_debug_all_events hello:hello >&$TEST_log \
|| fail "Build failed"
expect_not_log "Loading package: hello"
expect_log 'hello!'
Expand Down
12 changes: 6 additions & 6 deletions src/test/shell/integration/discard_graph_edges_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ function test_dump_after_discard_incrementality_data() {
function test_query_after_discard_incrementality_data() {
bazel build --nobuild --notrack_incremental_state //testing:mytest \
>& "$TEST_log" || fail "Expected success"
bazel query --noexperimental_ui --output=label_kind //testing:mytest \
bazel query --experimental_ui_debug_all_events --output=label_kind //testing:mytest \
>& "$TEST_log" || fail "Expected success"
expect_log "Loading package: testing"
expect_log "cc_test rule //testing:mytest"
Expand All @@ -452,19 +452,19 @@ function test_switch_back_and_forth() {
readonly local server_pid="$(bazel info \
--notrack_incremental_state server_pid 2> /dev/null)"
[[ -z "$server_pid" ]] && fail "Couldn't get server pid"
bazel test --noexperimental_ui --notrack_incremental_state \
bazel test --experimental_ui_debug_all_events --notrack_incremental_state \
//testing:mytest >& "$TEST_log" || fail "Expected success"
expect_log "Loading package: testing"
bazel test --noexperimental_ui --notrack_incremental_state \
bazel test --experimental_ui_debug_all_events --notrack_incremental_state \
//testing:mytest >& "$TEST_log" || fail "Expected success"
expect_log "Loading package: testing"
bazel test --noexperimental_ui //testing:mytest >& "$TEST_log" \
bazel test --experimental_ui_debug_all_events //testing:mytest >& "$TEST_log" \
|| fail "Expected success"
expect_log "Loading package: testing"
bazel test --noexperimental_ui //testing:mytest >& "$TEST_log" \
bazel test --experimental_ui_debug_all_events //testing:mytest >& "$TEST_log" \
|| fail "Expected success"
expect_not_log "Loading package: testing"
bazel test --noexperimental_ui --notrack_incremental_state \
bazel test --experimental_ui_debug_all_events --notrack_incremental_state \
//testing:mytest >& "$TEST_log" || fail "Expected success"
expect_log "Loading package: testing"
readonly local new_server_pid="$(bazel info server_pid 2> /dev/null)"
Expand Down

0 comments on commit 7b7a09f

Please sign in to comment.