Skip to content

Commit

Permalink
retain the OutputStore when include scanning
Browse files Browse the repository at this point in the history
this avoids information loss about injected output
metadata. this change resolves the TODO.

Progress towards #6862

Closes #7268.

PiperOrigin-RevId: 235774773
  • Loading branch information
buchgr authored and copybara-github committed Feb 26, 2019
1 parent 54e70a0 commit 5ce05a0
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -744,18 +744,14 @@ public void run(
state.inputArtifactData.putWithNoDepOwner(
ArtifactSkyKey.artifact(entry.getKey()), (FileArtifactValue) entry.getValue());
}
// TODO(ulfjack): This causes information loss about omitted and injected outputs. Also
// see the documentation on MetadataHandler.artifactOmitted. This works by accident
// because markOmitted is only called for remote execution, and this code only gets
// executed for local execution.
metadataHandler =
new ActionMetadataHandler(
state.inputArtifactData,
/*missingArtifactsAllowed=*/ false,
action.getOutputs(),
tsgm.get(),
metadataHandler.getArtifactPathResolver(),
state.actionFileSystem == null ? new OutputStore() : new MinimalOutputStore());
metadataHandler.getOutputStore());
}
}
Preconditions.checkState(!env.valuesMissing(), action);
Expand Down

0 comments on commit 5ce05a0

Please sign in to comment.