Skip to content

Commit

Permalink
deps: rules_python 0.4.0 -> 0.22.0
Browse files Browse the repository at this point in the history
Raise rules_python version to 0.22.0 so that py_proto_library is available.

The py_proto_library rule was introduced in 0.17.0, but there's been a variety
of fixes since then, so using a newer version is more advisable.

Note: A difference between 0.4.0 and 0.22.0 is that 0.4.0 calls `register_toolchains("@bazel_tools//tools/python:autodetecting_toolchain")`
to provide an extremely minimal, though incomplete, Python toolchain.
0.22.0 does not do that, and does not provide any Python toolchain by default.

Fixes #20315

PiperOrigin-RevId: 586758674
Change-Id: Ia479f4475d3bbbf048642470a3e33f272c2eba2e
  • Loading branch information
rickeylev authored and keertk committed Jan 17, 2024
1 parent debe29b commit 5551827
Show file tree
Hide file tree
Showing 5 changed files with 1,948 additions and 100 deletions.
16 changes: 11 additions & 5 deletions MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/MODULE.tools
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ bazel_dep(name = "rules_cc", version = "0.0.9")
bazel_dep(name = "rules_java", version = "7.1.0")
bazel_dep(name = "rules_license", version = "0.0.3")
bazel_dep(name = "rules_proto", version = "4.0.0")
bazel_dep(name = "rules_python", version = "0.4.0")
bazel_dep(name = "rules_python", version = "0.22.0")

bazel_dep(name = "platforms", version = "0.0.7")
bazel_dep(name = "protobuf", version = "3.19.6", repo_name = "com_google_protobuf")
Expand Down
1 change: 1 addition & 0 deletions src/test/py/bazel/bzlmod/bazel_module_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def setUp(self):
'build --java_language_version=8',
'build --tool_java_language_version=8',
'build --lockfile_mode=update',
'build --extra_toolchains=@bazel_tools//tools/python:autodetecting_toolchain' # fmt: skip pylint: disable=line-too-long
],
)

Expand Down
1 change: 1 addition & 0 deletions src/test/py/bazel/bzlmod/bazel_repo_mapping_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ def setUp(self):
'build --java_language_version=8',
'build --tool_java_language_version=8',
'build --lockfile_mode=update',
'build --extra_toolchains=@bazel_tools//tools/python:autodetecting_toolchain' # fmt: skip pylint: disable=line-too-long
],
)

Expand Down
Loading

0 comments on commit 5551827

Please sign in to comment.