Skip to content

Commit

Permalink
Automated rollback of commit 872c11a.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

This change introduced a performance regression in bazel.

More details in #9270.

*** Original change description ***

Allow G1 in tools/jdk/BUILD.java_tools.

This is a followup to 01e6e05. (I think BUILD.java_tools was introduced in between the creation of the PR for 01e6e05 and its landing.)

Closes #8964.

PiperOrigin-RevId: 272156477
  • Loading branch information
iirina authored and copybara-github committed Oct 1, 2019
1 parent 4aed638 commit 5142172
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions tools/jdk/BUILD.java_tools
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ java_toolchain(
javac = [":javac_jar"],
javac_supports_workers = 1,
jvm_opts = [
# In JDK9 we have seen a ~30% slow down in JavaBuilder performance when using
# G1 collector and having compact strings enabled.
"-XX:+UseParallelOldGC",
"-XX:-CompactStrings",
# Allow JavaBuilder to access internal javac APIs.
"--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
"--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED",
Expand Down Expand Up @@ -93,6 +97,10 @@ java_toolchain(
javac = [":javac_jar"],
javac_supports_workers = 1,
jvm_opts = [
# In JDK9 we have seen a ~30% slow down in JavaBuilder performance
# when using G1 collector and having compact strings enabled.
"-XX:+UseParallelOldGC",
"-XX:-CompactStrings",
# Allow JavaBuilder to access internal javac APIs.
"--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
"--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED",
Expand Down Expand Up @@ -154,6 +162,10 @@ java_toolchain(
javac = [":javac_jar"],
javac_supports_workers = 1,
jvm_opts = [
# In JDK9 we have seen a ~30% slow down in JavaBuilder performance when using
# G1 collector and having compact strings enabled.
"-XX:+UseParallelOldGC",
"-XX:-CompactStrings",
# Allow JavaBuilder to access internal javac APIs.
"--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
"--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED",
Expand Down

0 comments on commit 5142172

Please sign in to comment.