Don't iterate over a large map just to delete an empty list of SkyKeys.

RELNOTES: None. PiperOrigin-RevId: 229715756
bazelbuild · Jan 17, 2019 · 26d5a40 · 26d5a40
1 parent 4526b4b
commit 26d5a40
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
@@ -353,6 +353,10 @@ private void invalidateDeletedPackages(Iterable<PackageIdentifier> deletedPackag
     for (PackageIdentifier deletedPackage : deletedPackages) {
       packagesToInvalidate.add(PackageLookupValue.key(deletedPackage));
     }
+    // Exit early if there are no packages to be deleted to avoid iterating over a large map.
+    if (packagesToInvalidate.isEmpty()) {
+      return;
+    }
     memoizingEvaluator.delete(Predicates.in(packagesToInvalidate));
   }