Automated rollback of commit 0d2e9da.

*** Reason for rollback *** Rollforward - Regression with implicit deps when Automatic Exec Groups are enabled is fixed. *** Original change description *** Automated rollback of commit f548d56. *** Reason for rollback *** Introduces regression on implicit dependencies. *** Original change description *** Flip Automatic Exec Groups inside java_library PiperOrigin-RevId: 521449702 Change-Id: Ic4d59c558d381a279326d83ce24b3540900e21b8
bazelbuild · Apr 3, 2023 · 233ee29 · 233ee29
1 parent 788801a
commit 233ee29
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/main/starlark/builtins_bzl/common/java/android_lint.bzl b/src/main/starlark/builtins_bzl/common/java/android_lint.bzl
@@ -127,5 +127,6 @@ def android_lint_action(ctx, source_files, source_jars, compilation_info):
         tools = tools,
         arguments = args_list,
         execution_requirements = {"supports-workers": "1"},
+        toolchain = semantics.JAVA_TOOLCHAIN_TYPE,
     )
     return android_lint_out
diff --git a/src/main/starlark/builtins_bzl/common/java/java_library.bzl b/src/main/starlark/builtins_bzl/common/java/java_library.bzl
@@ -170,7 +170,10 @@ JAVA_LIBRARY_ATTRS = merge_attrs(
 
 java_library = rule(
     _proxy,
-    attrs = JAVA_LIBRARY_ATTRS,
+    attrs = merge_attrs(
+        JAVA_LIBRARY_ATTRS,
+        {"_use_auto_exec_groups": attr.bool(default = True)},
+    ),
     provides = [JavaInfo],
     outputs = {
         "classjar": "lib%{name}.jar",

diff --git a/src/main/starlark/builtins_bzl/common/java/proguard_validation.bzl b/src/main/starlark/builtins_bzl/common/java/proguard_validation.bzl
@@ -41,6 +41,7 @@ def _validate_spec(ctx, spec_file):
         arguments = [args],
         inputs = [spec_file],
         outputs = [validated_proguard_spec],
+        toolchain = Label(semantics.JAVA_TOOLCHAIN_TYPE),
     )
 
     return validated_proguard_spec