Mark test.xml omitted if it wasn't generated

bazelbuild · Dec 29, 2020 · 19b829b · 19b829b
1 parent b752e2b
commit 19b829b
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java b/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
@@ -773,18 +773,17 @@ public TestAttemptContinuation execute()
       }
 
 
+      MetadataHandler metadataHandler = actionExecutionContext.getMetadataHandler();
+
       Path xmlOutputPath = resolvedPaths.getXmlOutputPath();
       boolean testXmlExists = xmlOutputPath.exists();
-      if (!testXmlExists) {
-        MetadataHandler metadataHandler = actionExecutionContext.getMetadataHandler();
-        if (metadataHandler != null) {
+      if (!testXmlExists && metadataHandler != null) {
           try {
             // Check whether test.xml exists. If not, an IOException will be thrown.
             metadataHandler.getMetadata(testAction.getTestXml());
             testXmlExists = true;
           } catch (IOException ignored) {
           }
-        }
       }
 
       // If the test did not create a test.xml, and --experimental_split_xml_generation is enabled,
@@ -813,6 +812,10 @@ public TestAttemptContinuation execute()
         }
       }
 
+      if (metadataHandler != null) {
+          metadataHandler.markOmitted(testAction.getTestXml());
+      }
+
       TestCase details = parseTestResult(xmlOutputPath);
       if (details != null) {
         testResultDataBuilder.setTestCase(details);