Refactor to use switch expression pattern matching

now that b/330770905 is fixed. PiperOrigin-RevId: 624250262 Change-Id: If9844a7043476b2e74ca9defea853e30b840b6bb
bazelbuild · Apr 12, 2024 · 1115e52 · 1115e52
1 parent 6e6e862
commit 1115e52
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 21 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/serialization/testutils/Dumper.java b/src/main/java/com/google/devtools/build/lib/skyframe/serialization/testutils/Dumper.java
@@ -274,15 +274,12 @@ private boolean outputObjectFields(Object obj) {
   }
 
   private void outputField(Object parent, FieldInfo info) {
-    if (info instanceof PrimitiveInfo primitiveInfo) {
-      primitiveInfo.output(parent, out);
-    } else if (info instanceof ObjectInfo objectInfo) {
-      out.append(objectInfo.name()).append('=');
-      outputObject(objectInfo.getFieldValue(parent));
-    } else {
-      // TODO: b/297857068 - it should be possible to replace this with a pattern matching switch
-      // which won't require this line, but that's not yet supported.
-      throw new IllegalArgumentException("Unexpected FieldInfo type: " + info);
+    switch (info) {
+      case PrimitiveInfo primitiveInfo -> primitiveInfo.output(parent, out);
+      case ObjectInfo objectInfo -> {
+        out.append(objectInfo.name()).append('=');
+        outputObject(objectInfo.getFieldValue(parent));
+      }
     }
   }
 

diff --git a/...in/java/com/google/devtools/build/lib/skyframe/serialization/testutils/Fingerprinter.java b/...in/java/com/google/devtools/build/lib/skyframe/serialization/testutils/Fingerprinter.java
@@ -245,18 +245,15 @@ private int outputObjectFields(Object obj, StringBuilder out) {
       } else {
         out.append(", ");
       }
-      if (info instanceof PrimitiveInfo primitiveInfo) {
-        primitiveInfo.output(obj, out);
-      } else if (info instanceof ObjectInfo objectInfo) {
-        out.append(objectInfo.name()).append('=');
-        cycleOwnerIndex =
-            min(
-                cycleOwnerIndex,
-                outputFingerprintOrInlinedValue(objectInfo.getFieldValue(obj), out));
-      } else {
-        // TODO: b/297857068 - it should be possible to replace this with a pattern matching
-        // switch which won't require this line, but that's not yet supported.
-        throw new IllegalArgumentException("Unexpected FieldInfo type: " + info);
+      switch (info) {
+        case PrimitiveInfo primitiveInfo -> primitiveInfo.output(obj, out);
+        case ObjectInfo objectInfo -> {
+          out.append(objectInfo.name()).append('=');
+          cycleOwnerIndex =
+              min(
+                  cycleOwnerIndex,
+                  outputFingerprintOrInlinedValue(objectInfo.getFieldValue(obj), out));
+        }
       }
     }
     return cycleOwnerIndex;