Switch back the default for --incompatible_package_name_is_a_function

The value was changed in 4a8bacd, but it is breaking downstream projects #5827 RELNOTES: Revert the default of --incompatible_package_name_is_a_function to false. PiperOrigin-RevId: 212297376
bazelbuild · Sep 10, 2018 · 0211ef8 · 0211ef8
1 parent 53ad67f
commit 0211ef8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/site/docs/skylark/backward-compatibility.md b/site/docs/skylark/backward-compatibility.md
@@ -180,7 +180,7 @@ Likewise, the magic `REPOSITORY_NAME` variable is replaced by
 same flag.
 
 *   Flag: `--incompatible_package_name_is_a_function`
-*   Default: `true`
+*   Default: `false`
 
 
 ### FileType is deprecated

diff --git a/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java
@@ -316,7 +316,7 @@ public class SkylarkSemanticsOptions extends OptionsBase implements Serializable
 
   @Option(
       name = "incompatible_package_name_is_a_function",
-      defaultValue = "true",
+      defaultValue = "false",
       documentationCategory = OptionDocumentationCategory.SKYLARK_SEMANTICS,
       effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
       metadataTags = {

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
@@ -127,7 +127,7 @@ public static Builder builderWithDefaults() {
           .incompatibleGenerateJavaCommonSourceJar(false)
           .incompatibleNewActionsApi(false)
           .incompatibleNoSupportToolsInActionInputs(false)
-          .incompatiblePackageNameIsAFunction(true)
+          .incompatiblePackageNameIsAFunction(false)
           .incompatibleRangeType(false)
           .incompatibleRemoveNativeGitRepository(false)
           .incompatibleRemoveNativeHttpArchive(false)