Address review comments

bazelbuild · Jan 24, 2024 · 02055e6 · 02055e6
1 parent d91f396
commit 02055e6
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/main/java/net/starlark/java/eval/BuiltinFunction.java b/src/main/java/net/starlark/java/eval/BuiltinFunction.java
@@ -157,6 +157,9 @@ private Object[] getArgumentVector(
     ParamDescriptor[] parameters = desc.getParameters();
 
     // Fast case: reuse positional as Java argument vector
+    // StringModule methods, which are treated specially below, will never match this case since
+    // their "self" parameter is restricted to String and thus
+    // getPositionalsCanBeJavaArgumentVector() is false.
     if (desc.getPositionalsCanBeJavaArgumentVector()
         && positional.length == parameters.length
         && named.length == 0) {