Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Clarification of priority label semantics #339

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sventiffe
Copy link
Contributor

No description provided.

@sventiffe sventiffe requested review from meteorcloudy and removed request for jin and philwo January 26, 2022 09:20
any imminent release. May never be fixed.
any imminent release. May never be fixed by the Bazel team.
* Issues marked as P3 are not actively managed by the Bazel team.
Community contributions are encouraged, the Bazel team will accept PRs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to mention the help-wanted label somewhere around here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be a good statement?
A bullet point under P3 like "In particular, we welcome contributions to issues with the label "help wanted"." maybe?

While "help wanted" is not restricted to P3 issues, it would be the place where I would mainly expect that label.

any imminent release. May never be fixed.
any imminent release. May never be fixed by the Bazel team.
* Issues marked as P3 are not actively managed by the Bazel team.
Community contributions are encouraged, the Bazel team will accept PRs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a worry about the words "will accept PRs.", even with the "reach out" qualification in the next sentence. I want to avoid repeating our habit of lingering reviews of PRs that address an issue in the authors mind, but are not well thought out.

What about this concept:
Community contributions are welcome. Before sending a PR, please reach out in the issue first to discuss your solution and work with the Bazel team to find the best reviewer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with the suggested wording

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants