Search for a local npm installation #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this logic live within npm/index.js? It seems like it's a npm/node specific concern and having the logic live here wouldn't allow users to manually invoke the bin the want to override this logic |
|
Good call. I'm not too familiar with npm so it just didn't occur to me to handle this in the package entry point. I'll move the logic there when I get a chance. |
dougkoch
changed the title
dougkoch
force-pushed
the
run-npm-binary
branch
from
a3adef1 to
c685a75
Compare
|
This PR is ready to be reviewed again. |
alexeagle
added a commit
to alexeagle/bazel-watcher
that referenced
this pull request
Dec 4, 2017
Followup to bazelbuild#74 When we roll out the feature of searching for a locally installed ibazel, we need to communicate it to users, or they are not likely to discover it. Especially while ibazel is under active development, development workflows like browser livereload are sensitive to the ibazel version so I want to be sure users are not likely to trip on versioning.
achew22
pushed a commit
that referenced
this pull request
Dec 5, 2017
Followup to #74 When we roll out the feature of searching for a locally installed ibazel, we need to communicate it to users, or they are not likely to discover it. Especially while ibazel is under active development, development workflows like browser livereload are sensitive to the ibazel version so I want to be sure users are not likely to trip on versioning.
borkaehw
pushed a commit
to lucidsoftware/bazel-watcher
that referenced
this pull request
Jul 30, 2018
Make index.js look for a local installation
borkaehw
pushed a commit
to lucidsoftware/bazel-watcher
that referenced
this pull request
Jul 30, 2018
Followup to bazelbuild#74 When we roll out the feature of searching for a locally installed ibazel, we need to communicate it to users, or they are not likely to discover it. Especially while ibazel is under active development, development workflows like browser livereload are sensitive to the ibazel version so I want to be sure users are not likely to trip on versioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #45