Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable echoing CMD code in copy_directory and copy_file rules on Windows #389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zpervan
Copy link

@zpervan zpervan commented Sep 1, 2022

While copying directories or files into the build folders, the CMD commands tend to be visible during the build process which could be confusing or misleading if something gets broken during the build process.

This just disables echoing commands from copy_directory and copy_file.

Example:
image

@google-cla
Copy link

google-cla bot commented Sep 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@zpervan zpervan force-pushed the disable-echo-cmd-copy-dir-file-windows branch from 5394065 to e83bf25 Compare September 15, 2022 07:36
@zpervan zpervan force-pushed the disable-echo-cmd-copy-dir-file-windows branch from e83bf25 to ff1ad48 Compare September 15, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant