Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Add Windows support #96

Closed
wants to merge 6 commits into from
Closed

Conversation

jchv
Copy link

@jchv jchv commented Nov 11, 2018

WIP. Depends on the update to rules_go in #95.

Java tests are failing quietly, I can't find any relevant logs yet.

@achew22
Copy link
Member

achew22 commented Nov 11, 2018

@jchv it might be worth patching in #94 so that you can get buildkite to build for windows as well which may provide some useful feedback

@jchv
Copy link
Author

jchv commented Nov 11, 2018

@jchv it might be worth patching in #94 so that you can get buildkite to build for windows as well which may provide some useful feedback

Good idea. Almost all of the changes in that PR would conflict with mine, so I just copied the presubmit.yml changes for now.

@ittaiz
Copy link
Member

ittaiz commented Nov 11, 2018

Well done!
This repo currently works on RBE and it's paramount we keep it like this. I'll try today/tomorrow to get #83 to pass so you'll be able to rebase off of that.

@meteorcloudy
Copy link
Member

meteorcloudy commented Feb 21, 2019

@jchv Are you still working on this? Is there anything we can do to help? Thanks!

@jchv
Copy link
Author

jchv commented Feb 21, 2019

Ah, yeah, I am. I'm a bit confused as to what to do with the RBE support, however.

@achew22
Copy link
Member

achew22 commented Feb 21, 2019

@jchv, according to the presubmit definition, this repo doesn't test against RBE and #103 which adds it seems to be stalled. @ittaiz if you have more information on that we should take it into consideration but my plan is to merge this if we get the windows tests passing. Hopefully there won't be too much toe stomping.

@meteorcloudy meteorcloudy mentioned this pull request Mar 12, 2019
@ittaiz
Copy link
Member

ittaiz commented Apr 28, 2019

Is this still alive?

@meteorcloudy
Copy link
Member

We can close this one since Windows support is added at #117

@jchv
Copy link
Author

jchv commented Apr 29, 2019

Sorry about that! Forgot to close it when it was superceded.

@jchv jchv deleted the windows-support branch April 29, 2019 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants