Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM toolchain #923

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Add LLVM toolchain #923

merged 3 commits into from
Sep 20, 2023

Conversation

siddharthab
Copy link
Contributor

@siddharthab siddharthab commented Sep 14, 2023

New module [email protected].

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Sep 14, 2023
@siddharthab
Copy link
Contributor Author

All tests are now passing.

@fmeum
Copy link
Contributor

fmeum commented Sep 20, 2023

@meteorcloudy @Wyverald I personally agree with the somewhat generic name as this really is the LLVM Bazel toolchain, just want to confirm this with you before I hit merge.

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@meteorcloudy meteorcloudy merged commit 5429173 into bazelbuild:main Sep 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants