-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected], [email protected] #3171
[email protected], [email protected] #3171
Conversation
Hello @rickeylev, @f0rmiga, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR. Please review the changes. |
Hello @aignas, modules you maintain (rules_python) have been updated in this PR. Please review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
Can we drop Bazel 6 for Bzlmod support? Bazel 7 had tons of Bzlmod improvement ( |
And maybe add |
Yes, we dropped bazel 6 bzlmod with this release. I have bazelbuild/rules_python#2404 to fix that upstream. I started #3180 to verify adding bazel 8.x to presubmit.yml actually works (It should 😅, but this is the first run of it under BCR). So, you can force merge this (all the failures are Bazel 6, so fine to ignore), or un-draft 3180 and merge that instead (it's a copy of this, but with presubmit.yml changes). |
I've switched #3180 to non-draft. Let's close this in favor of that one. It, at the least, has green presubmits. |
BCR config for rules_python and rules_python_gazelle_plugin 0.39.0 This is #3171, but with presubmit changes to remove Bazel 6 from the test matrix.
Release: https://github.com/bazelbuild/rules_python/releases/tag/0.39.0
Automated by Publish to BCR