Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update migrate_to_bzlmod.py script #2966

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Update migrate_to_bzlmod.py script #2966

wants to merge 9 commits into from
+154 −49

Conversation

meteorcloudy
Copy link
Member

Improvements:

  • Polished some error messages.
  • Find BCR modules by looking at the urls (http_archive) or git source repo (git_repository)
  • Prefer to use use_repo_rule to introduce non-native deps
  • Deal with invalid workspace resolved file caused by (_action_listener) (Fixes [Bug]: tools/migrate_to_bzlmod crashes #2789)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Awaiting requested review from Wyverald

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: tools/migrate_to_bzlmod crashes
1 participant
@meteorcloudy