Add [email protected] #2498
Merged
Add [email protected] #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two things from 1.3.1.bcr.2: - added missing visibility declaration in new alias target (see 152ddc4#r144633540) - added proper quoting for the Batch copy command to avoid problems with the `+` character (see bazelbuild/bazel#22865 (comment))
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (zlib) have been updated in this PR. Please review the changes. |
Wyverald
referenced
this pull request
Jul 26, 2024
fmeum
approved these changes
Jul 26, 2024
|
We probably want to update zlib in https://cs.opensource.google/bazel/bazel/+/master:src/MODULE.tools;l=16?q=MODULE.tools&ss=bazel to this version before flipping that flag. |
meteorcloudy
added a commit
that referenced
this pull request
Oct 25, 2024
zlib version 1.3.1.bcr.3 resolved some build issues as per the description in the PR #2498 --------- Co-authored-by: Yun Peng <[email protected]>
asa
pushed a commit
to asa/bazel-central-registry
that referenced
this pull request
Oct 27, 2024
zlib version 1.3.1.bcr.3 resolved some build issues as per the description in the PR bazelbuild#2498 --------- Co-authored-by: Yun Peng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two things from 1.3.1.bcr.2:
+character (see Defining C++ repos with module 'use_repo_rule' impacts windows (msvc/clang-cl) compile speed by up to 5x - tildes? bazel#22865 (comment))