Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #1731

Merged
merged 6 commits into from
Apr 12, 2024
Merged

[email protected] #1731

merged 6 commits into from
Apr 12, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 1, 2024

@bazel-io
Copy link
Member

bazel-io commented Apr 1, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_fuzzing) have been updated in this PR. Please review the changes.

Copy link
Contributor

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! @stefanbucur is currently working on the last steps for setting up the automated BCR publishing flow for rules_fuzzing. Let's wait for a bit before we add this manually.

@mmorel-35
Copy link
Contributor Author

Will it's work apply with 0.5.1 or is this going to need a new version ?
If it requires a new version, this one can be added or am I missing something ?

@fmeum
Copy link
Contributor

fmeum commented Apr 1, 2024

If it requires a new version, this one can be added or am I missing something ?

That's true, but we need to ensure that the next release is API compatible. That's why I would at least want to wait for @stefanbucur's approval.

@mmorel-35
Copy link
Contributor Author

Any news from @stefanbucur ?

@meteorcloudy
Copy link
Member

I chatted with @stefanbucur, he probably don't have capacity to actually maintain this BCR module, and in future, we'll probably move rules_fuzzing to bazel-contrib.

@fmeum
Copy link
Contributor

fmeum commented Apr 8, 2024

@meteorcloudy Would he be okay with me becoming the BCR maintainer?

@meteorcloudy
Copy link
Member

Yes, that's definitely fine!

@stefanbucur
Copy link

Yes, that's definitely fine!

+1, I think Fabian would be most qualified to maintain rules_fuzzing moving forward. Nowadays I have very little time on my end and I often am the bottleneck in reviewing & approving PRs too.

@fmeum
Copy link
Contributor

fmeum commented Apr 9, 2024

@mmorel-35 Could you add my contact info (you can get it from rules_go) here instead of Stefan's? You also have to exclude the replay test as it pulls in googletest. Then we can merge this, thanks for working on it!

@mmorel-35
Copy link
Contributor Author

@fmeum ,
How do you ship/ignore a target ?

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Apr 9, 2024
This was referenced Apr 12, 2024
@keith
Copy link
Member

keith commented Apr 12, 2024

would be great if we could merge this so i could use it in #1807

@stefanbucur
Copy link

would be great if we could merge this so i could use it in #1807

@fmeum Is there something on my end that you folks are blocked on?

@fmeum
Copy link
Contributor

fmeum commented Apr 12, 2024

@stefanbucur No, I just didn't realize that this was updated and the checks were failing.

Bazel 6 support is lacking due to a bug fixed by bazel-contrib/rules_fuzzing#248, but this can wait for a new release. Testing the main repo itself was buggy for various reasons, but that's to be expected. Just testing the test module makes more sense and that works.

@fmeum fmeum merged commit a94967a into bazelbuild:main Apr 12, 2024
10 checks passed
@keith
Copy link
Member

keith commented Apr 12, 2024

thanks!

@mmorel-35 mmorel-35 deleted the rules_fuzzing/v0.5.1 branch April 12, 2024 15:27
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wanted: bazelbuild/rules_fuzzing
6 participants