-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] #1731
[email protected] #1731
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_fuzzing) have been updated in this PR. Please review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! @stefanbucur is currently working on the last steps for setting up the automated BCR publishing flow for rules_fuzzing. Let's wait for a bit before we add this manually.
Will it's work apply with 0.5.1 or is this going to need a new version ? |
42c71b5
to
2345f95
Compare
That's true, but we need to ensure that the next release is API compatible. That's why I would at least want to wait for @stefanbucur's approval. |
2345f95
to
6d1a615
Compare
Any news from @stefanbucur ? |
I chatted with @stefanbucur, he probably don't have capacity to actually maintain this BCR module, and in future, we'll probably move rules_fuzzing to bazel-contrib. |
@meteorcloudy Would he be okay with me becoming the BCR maintainer? |
Yes, that's definitely fine! |
+1, I think Fabian would be most qualified to maintain |
@mmorel-35 Could you add my contact info (you can get it from rules_go) here instead of Stefan's? You also have to exclude the |
@fmeum , |
would be great if we could merge this so i could use it in #1807 |
@stefanbucur No, I just didn't realize that this was updated and the checks were failing. Bazel 6 support is lacking due to a bug fixed by bazel-contrib/rules_fuzzing#248, but this can wait for a new release. Testing the main repo itself was buggy for various reasons, but that's to be expected. Just testing the test module makes more sense and that works. |
thanks! |
Release: https://github.com/bazelbuild/rules_fuzzing/releases/tag/v0.5.1 Closes bazelbuild#1728 --------- Co-authored-by: Fabian Meumertzheim <[email protected]>
Release: https://github.com/bazelbuild/rules_fuzzing/releases/tag/v0.5.1
Closes #1728