Merged
[email protected] #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Vertexwahn, @c8ef, modules you maintain (spdlog) have been updated in this PR. Please review the changes. |
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
Vertexwahn
suggested changes
Dec 15, 2024
|
Can we test also the |
jwnimmer-tri
force-pushed
the
spdlog-1.15.0.bcr.2
branch
from
c2b3b2b to
c9e5f01
Compare
|
Good idea; test added. |
Vertexwahn
previously approved these changes
Dec 15, 2024
bazel-io
previously approved these changes
Dec 15, 2024
c8ef
previously approved these changes
Dec 16, 2024
fmeum
added
the
presubmit-auto-run
auto-merge was automatically disabled
December 16, 2024 23:30
Head branch was pushed to by a user without write access
jwnimmer-tri
force-pushed
the
spdlog-1.15.0.bcr.2
branch
from
c9e5f01 to
374a7fe
Compare
bazel-io
dismissed stale reviews from Vertexwahn, c8ef, and themself
Require module maintainers' approval for newly pushed changes.
Add bool_flag for header_only mode. This enables `--@spdlog//:header_only=False` on the bazel command line. Requires a new dependency on @bazel_skylib. Add bazel_compatibility metadata to ensure that overlay is supported. Add bazel 8.x to presubmit testing. Add /utf-8 for windows presubmit testing.
jwnimmer-tri
force-pushed
the
spdlog-1.15.0.bcr.2
branch
from
374a7fe to
4a33411
Compare
|
The new presubmit matrix was failing on windows with UTF-8 complaints. I added |
Vertexwahn
approved these changes
Dec 17, 2024
bazel-io
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to
1.15.0.bcr.1, add abool_flagfor header_only mode and now depends on@bazel_skylib.This enables
--@spdlog//:header_only=Falseon the bazel command line.See also #1769 which requests a mechanism to enable
USE_STD_FORMAT. If desirable, I could try adding that option as an additional flag in this pull request, or in a follow-up change.