Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wanted: spdlog with std::format #1769

Open
1 task
calebzulawski opened this issue Apr 5, 2024 · 3 comments
Open
1 task

wanted: spdlog with std::format #1769

calebzulawski opened this issue Apr 5, 2024 · 3 comments
Labels
module wanted Users want a certain module to be available in the BCR, contributions are welcome!

Comments

@calebzulawski
Copy link
Contributor

Module location

https://github.com/gabime/spdlog

Link to bzlmod issue in the module's repository

No response

Any other context to provide?

This module exists, but it would be nice to have a cc_library variation that uses SPDLOG_USE_STD_FORMAT and doesn't have a dependency on @fmt

cc @Vertexwahn

Fund our work

  • Sponsor our community's open source work by donating a feature bounty
@calebzulawski calebzulawski added the module wanted Users want a certain module to be available in the BCR, contributions are welcome! label Apr 5, 2024
@aaronmondal
Copy link

FYI @calebzulawski slightly outdated and doesn't use rules_cc, but might give some inspiration:

@fmeum
Copy link
Contributor

fmeum commented Apr 28, 2024

I'm working on a feature system for Bazel modules (similar to that from Cargo), which could be a way to make this configurable.

@calebzulawski
Copy link
Contributor Author

I'm working on a feature system for Bazel modules (similar to that from Cargo), which could be a way to make this configurable.

That sounds great, exactly what I was curious about. Thank you!

fmeum pushed a commit that referenced this issue Dec 17, 2024
Compared to `1.15.0.bcr.1`, add a `bool_flag` for header_only mode and
now depends on `@bazel_skylib`.

This enables `--@spdlog//:header_only=False` on the bazel command line.

---

See also #1769 which requests a mechanism to enable `USE_STD_FORMAT`. If
desirable, I could try adding that option as an additional flag in this
pull request, or in a follow-up change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module wanted Users want a certain module to be available in the BCR, contributions are welcome!
Projects
None yet
Development

No branches or pull requests

3 participants