Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--bazel_binaries flag #66

Merged
merged 4 commits into from
Sep 4, 2019
Merged

--bazel_binaries flag #66

merged 4 commits into from
Sep 4, 2019

Conversation

joeleba
Copy link
Member

@joeleba joeleba commented Sep 3, 2019

What this PR does and why we need it:

This PR adds a new flag --bazel_binaries to allow benchmarking of pre-built bazel binaries.
Other changes:

  • The script now fails if one of the specified bazel commits doesn't exist in the master branch of the specified repo.
  • Added a more prominent message in the log to stdout

@joeleba joeleba requested a review from meisterT September 3, 2019 12:35
meisterT
meisterT approved these changes Sep 4, 2019
View reviewed changes
benchmark.py Outdated Show resolved Hide resolved
@joeleba joeleba merged commit ae97c6a into master Sep 4, 2019
@joeleba joeleba deleted the benchmark_binary branch September 4, 2019 08:54
@joeleba joeleba mentioned this pull request Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeleba @meisterT