-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazelize bazel-bench #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get:
DEBUG: Rule 'io_bazel_rules_python' indicated that a canonical reproducible form can be obtained by modifying arguments shallow_since = "1551999322 -0500"
and three failing tests (the build succeeds). Is that expected?
Not sure if these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some changes. You shouldn't need pip
and virtualenv
now. Just bazel
.
@Globegitter thanks for the recommendation! Yes, those were generated by hand. |
@@ -73,6 +72,8 @@ def upload_csv(csv_file_path, bigquery_cfg): | |||
bigquery_cfg: The string representing the BigQuery table config. Comes in | |||
the form <dataset_id>:<table_id>:<location> | |||
""" | |||
from google.cloud import bigquery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation to move this import down here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a workaround of bazelbuild/rules_python#14 for bazel test
to work.
What this PR does and why we need it:
This PR enables the use of Bazel to build & test
bazel-bench
.New changes / Issues that this PR fixes:
Special notes for reviewer:
If possible, try to clone and set up the project from scratch.
Does this require a change in the script's interface or the BigQuery's table structure?
No