Main module builds and tests pass for boost.chrono
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's fine. the bazel tests don't have to be perfect. Just enough to make sure the bazel module works. I added a github action to run the tests. When we're green then I'll get it merged in! |
|
Okay Ill keep modifying until it gets green! |
|
Added a missing |
zaucy
approved these changes
Apr 7, 2024
|
Looks like the boost autolinker is enabled causing the windows ci to fail. Generally I've been disabling this since an autolinker doesn't make much sense with bazel built projects. |
|
i disabled autolink to get it through! Thanks so much :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only tests omitted return failure on purpose. I looked into how to fix this and you have to create a nasty custom build rule which I thought was out of scope of this change.