Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_apple to 2.3.0 + remove bitcode support #727

Merged

Conversation

mattrobmattrob
Copy link
Collaborator

@mattrobmattrob mattrobmattrob marked this pull request as ready for review June 1, 2023 16:33
@mattrobmattrob mattrobmattrob requested review from thiagohmcruz and luispadron and removed request for thiagohmcruz June 1, 2023 16:33
@mattrobmattrob mattrobmattrob enabled auto-merge (squash) June 1, 2023 16:39
Copy link
Contributor

@thiagohmcruz thiagohmcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect the code being removed to break the "Bazel 5 + old rules_apple" code path? Any way we can verify that?

@luispadron
Copy link
Collaborator

I'm not entirely sure why we're supporting two Bazel versions on main. Should we not instead create a branch specifically for Bazel 5? This makes maintenance really tough...

@mattrobmattrob
Copy link
Collaborator Author

I was relying on Tests / Build and Test ( Virtual Frameworks + LTS ) to verify the Bazel 5/LTS codepath. Do you think it's not good enough, @thiagohmcruz?

@thiagohmcruz
Copy link
Contributor

Oh my bad, forgot that there's an explicitly job to cover that, it should be enough yeah

@luispadron there's a README IIRC to cover the LTS support, maybe a start is to review that and propose changes / a diff approach?

I def can see the pain points in maintaining it, at the same time it was introduced to help enforce there is at least one code path we consider "stable". That said, there's other ways to achieve the same thing and any approach will have trade-offs to discuss IMO.

@mattrobmattrob mattrobmattrob merged commit 450b4d7 into bazel-ios:master Jun 1, 2023
@mattrobmattrob mattrobmattrob deleted the mr/remove.bitcode.support branch June 1, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants