[RBE] Plumb missing exec_properties field #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrymarino
force-pushed
the
jmarino/test_exec_properties
branch
from
e1b1b8d to
2beef04
Compare
justinseanmartin
approved these changes
Feb 24, 2023
thiagohmcruz
approved these changes
Feb 24, 2023
Thank to bazelbuild/bazel#10799 we now have `exec_properties` and the tests are missing `exec_properties`, so set them. If you have different exec properties for inputs, you can set them with `exec_properties` Conditional to not expand the size of the action graph
jerrymarino
force-pushed
the
jmarino/test_exec_properties
branch
from
2beef04 to
39a2226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank to bazelbuild/bazel#10799 we now have
exec_propertiesand the tests are missingexec_properties, so set them. If you have different exec properties for inputs, you can set them withexec_propertiesConditional to not expand the size of the action graph