Skip to content

Commit

Permalink
[7.2.1] Add missing category submessage. (bazelbuild#22828)
Browse files Browse the repository at this point in the history
Fixes bazelbuild#22741.

PiperOrigin-RevId: 643932127
Change-Id: Ia9566acb7b828224679ad57b71644281a8e52db4

Co-authored-by: Googler <[email protected]>
  • Loading branch information
Wyverald and coeuvre authored Jun 20, 2024
1 parent 5128698 commit 3278ffd
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// limitations under the License.
package com.google.devtools.build.lib.skyframe;

import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.util.concurrent.MoreExecutors.directExecutor;

import com.google.common.collect.ImmutableCollection;
Expand Down Expand Up @@ -56,6 +55,7 @@
import com.google.devtools.build.lib.events.Event;
import com.google.devtools.build.lib.events.ExtendedEventHandler;
import com.google.devtools.build.lib.server.FailureDetails.FailureDetail;
import com.google.devtools.build.lib.server.FailureDetails.RemoteExecution;
import com.google.devtools.build.lib.skyframe.ArtifactFunction.MissingArtifactValue;
import com.google.devtools.build.lib.skyframe.ArtifactFunction.SourceArtifactException;
import com.google.devtools.build.lib.skyframe.MetadataConsumerForMetrics.FilesMetricConsumer;
Expand Down Expand Up @@ -433,7 +433,15 @@ private void ensureToplevelArtifacts(
action,
true,
DetailedExitCode.of(
FailureDetail.newBuilder().setMessage(e.getMessage()).build()))),
FailureDetail.newBuilder()
.setMessage(e.getMessage())
.setRemoteExecution(
RemoteExecution.newBuilder()
.setCode(
RemoteExecution.Code
.TOPLEVEL_OUTPUTS_DOWNLOAD_FAILURE)
.build())
.build()))),
directExecutor()));
}
}
Expand Down
1 change: 1 addition & 0 deletions src/main/protobuf/failure_details.proto
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ message RemoteExecution {
[(metadata) = { exit_code: 1 }];
ILLEGAL_OUTPUT = 15 [(metadata) = { exit_code: 1 }];
INVALID_EXEC_AND_PLATFORM_PROPERTIES = 16 [(metadata) = { exit_code: 1 }];
TOPLEVEL_OUTPUTS_DOWNLOAD_FAILURE = 17 [(metadata) = { exit_code: 34 }];
}

Code code = 1;
Expand Down

0 comments on commit 3278ffd

Please sign in to comment.