Skip to content

Commit

Permalink
[JSON Trace Profile] Correctly identify GC thread
Browse files Browse the repository at this point in the history
Currently, the thread that includes the garbage collection notification events is not correctly identified.
This means that in the JSON trace profile, the thread:

* is not renamed, as desired.
* is not sorted towards the top, as desired.

The thread is identified by its name, which has changed from "Service Thread" to "Notification Thread". This change updates the profile code accordingly.

In response to bazelbuild#18548 (comment)
Fixes EngFlow/bazel_invocation_analyzer#110

Closes bazelbuild#20299.

PiperOrigin-RevId: 585639069
Change-Id: Id4aadb5451839b5be07ac98428f9367764ff46ce
  • Loading branch information
saraadams authored and bazel-io committed Nov 27, 2023
1 parent 4260c15 commit 07d0a8d
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ private static boolean isMainThread(String threadName) {
}

private static boolean isGCThread(String threadName) {
return threadName.equals("Service Thread");
return threadName.equals("Notification Thread");
}

private static String getReadableName(String threadName) {
Expand Down

0 comments on commit 07d0a8d

Please sign in to comment.