Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fencing for npm packages #946

Merged
merged 1 commit into from
Jul 30, 2019
Merged

fix: fencing for npm packages #946

merged 1 commit into from
Jul 30, 2019

Conversation

gregmagolan
Copy link
Collaborator

and other minor cleanups

@gregmagolan
fix: fencing for npm packages
8b2d652 
and other minor cleanups
@gregmagolan gregmagolan requested a review from alexeagle July 30, 2019 00:17
@gregmagolan gregmagolan requested a review from kyliau as a code owner July 30, 2019 00:17
alexeagle
alexeagle approved these changes Jul 30, 2019
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm we didn't have any test coverage to catch this leak :(

@gregmagolan
Copy link
Collaborator Author

hmm we didn't have any test coverage to catch this leak :(

I'll add some in a follow up PR

@gregmagolan gregmagolan merged commit 780dfb4 into bazel-contrib:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@kyliau kyliau Awaiting requested review from kyliau

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregmagolan @alexeagle @googlebot