Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create): add workers flags #865

Merged
merged 2 commits into from
Jun 17, 2019
Merged

feat(create): add workers flags #865

merged 2 commits into from
Jun 17, 2019

Conversation

alexeagle
Copy link
Collaborator

This should help users stay on the happy path

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@gregmagolan
Copy link
Collaborator

gregmagolan commented Jun 14, 2019 •
edited
Loading 

ERROR: /home/circleci/rules_nodejs/e2e/karma_stack_trace/BUILD.bazel:22:1: Compiling TypeScript (devmode) //:test_lib failed (Exit 1)
error TS2688: Cannot find type definition file for 'long'.
error TS2688: Cannot find type definition file for 'node'.

Same failures I saw in #861. Likely related to worker mode in 0.27.0rc5 then.

@alexeagle
Copy link
Collaborator Author

It's bazelbuild/rules_typescript#449 - not related to recent Bazel I think

@alexeagle alexeagle force-pushed the create branch 2 times, most recently from 7a54f7b to 8224f4f Compare June 14, 2019 17:12
@alexeagle alexeagle changed the title feat(create): add workers and verbose_failures flags feat(create): add workers flags Jun 14, 2019
@alexeagle alexeagle force-pushed the create branch 6 times, most recently from 5e65c5f to 3560379 Compare June 15, 2019 00:19
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

alexeagle
alexeagle commented Jun 17, 2019
View reviewed changes
e2e/ts_library/reference_types_directive/BUILD.bazel
@@ -7,7 +7,7 @@ ts_library(
expected_diagnostics = [
"TS2304: Cannot find name 'Hammer'",
],
node_modules = "@npm//:node_modules",
node_modules = "@npm//:node_modules_filegroup",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes me think it's a breaking change. I hoped we could keep the old code building?

Copy link
Collaborator

@gregmagolan gregmagolan Jun 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because @npm//:node_modules is now a node_modules_library and no longer a filegroup and the rules_typescript change makes ts_library now all of its .d.ts files and stamp out the types in tsconfig this ts_library now successfully compiles. This test was checking for the missing dep "TS2304: Cannot find name 'Hammer'" so for the test to work as designed the node_modules must be a plain filegroup.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

alexeagle
alexeagle commented Jun 17, 2019
View reviewed changes
e2e/ts_library/WORKSPACE
@@ -26,6 +26,14 @@ load("@build_bazel_rules_nodejs//:defs.bzl", "yarn_install")

yarn_install(
name = "npm",
manual_build_file_contents = """
filegroup(
name = "node_modules_filegroup",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment here that this is to exclude hammerjs because the test asserts that it's missing?

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@alexeagle
fix(typescript): fix issue with types[] in non-sandboxed tsc
e578048 
To make worker mode work with TypeScript ambient type discovery, always
zero out the compilerOptions#types in the generated tsconfig - users
should provide these as deps[] instead.

Fixes bazelbuild/rules_typescript#449
@alexeagle alexeagle merged commit 08b231a into bazel-contrib:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@kyliau kyliau Awaiting requested review from kyliau

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeagle @gregmagolan @googlebot