Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable our one py_test #842

Merged
merged 1 commit into from
Jun 11, 2019
Merged

test: disable our one py_test #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,10 @@ import %workspace%/common.bazelrc
# Mock versioning command to test the --stamp behavior
build --workspace_status_command="echo BUILD_SCM_VERSION 1.2.3"

# Avoid python 3 which requires explicit toolchain config
# This is needed only for the pkg_tar rule
build --host_force_python=PY2

# Opt-in to upcoming breaking changes
build --incompatible_use_python_toolchains
common --incompatible_string_join_requires_strings
3 changes: 3 additions & 0 deletions internal/common/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ py_test(
size = "small",
srcs = ["check_version_test.py"],
data = [":check_version.bzl"],
# Explicitly pin to Python 2 to avoid toolchain configuration
# TODO(alexeagle): switch to starlark test mechanism
python_version = "PY2",
)

filegroup(
Expand Down