Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing progress_message to actions #706

Merged
merged 1 commit into from
Apr 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/parcel/parcel.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def _parcel_impl(ctx):
executable = ctx.executable.parcel,
outputs = [ctx.outputs.bundle, ctx.outputs.sourcemap],
arguments = args,
progress_message = "Running Parcel to produce %s" % ctx.outputs.bundle.path,
progress_message = "Bundling JavaScript %s [parcel]" % ctx.outputs.bundle.short_path,
)
return [DefaultInfo()]

Expand Down
1 change: 1 addition & 0 deletions internal/npm_package/npm_package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ def create_package(ctx, deps_sources, nested_packages):
inputs.append(ctx.version_file)

ctx.actions.run(
progress_message = "Assembling npm package %s" % package_dir.short_path,
executable = ctx.executable._packager,
inputs = inputs,
outputs = [package_dir, ctx.outputs.pack, ctx.outputs.publish],
Expand Down
4 changes: 4 additions & 0 deletions internal/rollup/rollup_bundle.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ def _run_rollup(ctx, sources, config, output, map_output = None):
outputs += [map_output]

ctx.actions.run(
progress_message = "Bundling JavaScript %s [rollup]" % output.short_path,
executable = ctx.executable._rollup,
inputs = depset(direct_inputs, transitive = [sources]),
outputs = outputs,
Expand All @@ -227,6 +228,7 @@ def _run_tsc(ctx, input, output):
args.add_all(["--outFile", output.path])

ctx.actions.run(
progress_message = "Downleveling JavaScript to ES5 %s [typescript]" % output.short_path,
executable = ctx.executable._tsc,
inputs = [input],
outputs = [output],
Expand All @@ -242,6 +244,7 @@ def _run_tsc_on_directory(ctx, input_dir, output_dir):
args.add_all(["--output", output_dir.path])

ctx.actions.run(
progress_message = "Downleveling JavaScript to ES5 %s [typescript]" % output_dir.short_path,
executable = ctx.executable._tsc_directory,
inputs = [input_dir],
outputs = [output_dir, config],
Expand Down Expand Up @@ -314,6 +317,7 @@ def _run_terser(ctx, input, output, map_output, debug = False, comments = True,
args.add("--beautify")

ctx.actions.run(
progress_message = "Optimizing JavaScript %s [terser]" % output.short_path,
executable = ctx.executable._terser_wrapped,
inputs = inputs,
outputs = outputs,
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/webpack/src/webpack_bundle.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def _webpack_bundle(ctx):
executable = ctx.executable.webpack,
outputs = [ctx.outputs.bundle, ctx.outputs.sourcemap],
arguments = [args],
progress_message = "Bundling with Webpack: %s" % ctx.outputs.bundle.path,
progress_message = "Bundling JavaScript %s [webpack]" % ctx.outputs.bundle.path,
)
return [DefaultInfo()]

Expand Down