Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup package_example #670

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Cleanup package_example #670

merged 1 commit into from
Apr 8, 2019

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Apr 6, 2019 •
edited
Loading

@gregmagolan gregmagolan requested a review from kyliau April 6, 2019 03:14
@gregmagolan gregmagolan requested a review from alexeagle as a code owner April 6, 2019 03:14
@gregmagolan gregmagolan force-pushed the cleanup-3 branch 3 times, most recently from c7311a6 to 0534cc5 Compare April 6, 2019 03:32
@gregmagolan
Cleanup package_example
bb09aca 
* rename workspace to internal_e2e_packages
* separate folders for each yarn_install & npm_install as prefactor for user node_modules
@alexeagle alexeagle merged commit cd21aa1 into bazel-contrib:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyliau kyliau kyliau approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gregmagolan @kyliau @alexeagle @googlebot