Fix //internal/npm_install/test:test for Windows and re-enable Windows tests on bazel CI #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
tests/npm-install-test-on-windows
branch
from
c890dcb to
28223c9
Compare
gregmagolan
commented
Feb 12, 2019
…-enable Windows tests on BazelCI
gregmagolan
force-pushed
the
tests/npm-install-test-on-windows
branch
from
0657d4d to
bf0adfc
Compare
gregmagolan
changed the title
alexeagle
approved these changes
Feb 13, 2019
| @@ -12,7 +12,6 @@ filegroup( | |||
| filegroup( | |||
| name = "test-a__files", | |||
| srcs = [ | |||
| ":.bin/test", | |||
There was a problem hiding this comment.
is this change intentional?
There was a problem hiding this comment.
That comes with the yarn update. It no longer creates those files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates the default yarn to 1.12.3 as 1.12.1 was messing up symlinks when testing locally on Windows.
I fixed
//internal/npm_install/test:testhere but disabled two failing web_package tests on Windows (//cc @alexeagle)@alexeagle Can you mirror yarn v1.12.3 at mirror.bazel.build?
https://github.com/yarnpkg/yarn/releases/download/v1.12.3/yarn-v1.12.3.tar.gz=>https://mirror.bazel.build/github.com/yarnpkg/yarn/releases/download/v1.12.3/yarn-v1.12.3.tar.gz