Fix += for lists in jasmine_node_test #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'+=' for lists now mutates the lhs list instead of creating a new one and assigning to lhs (https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#mutating). This is a fix for https://ci.bazel.io/blue/organizations/jenkins/Global%2Frules_nodejs/detail/rules_nodejs/56/pipeline/
|
Friendly pin @alexeagle |
alexeagle
approved these changes
Oct 25, 2017
|
Thanks! |
alexeagle
added a commit
to alexeagle/rules_nodejs
that referenced
this pull request
Oct 17, 2020
Fixes bazel-contrib#41 Closes bazel-contrib#42 PiperOrigin-RevId: 169476478
alexeagle
added a commit
to alexeagle/rules_nodejs
that referenced
this pull request
Oct 18, 2020
Fixes bazel-contrib#41 Closes bazel-contrib#42 PiperOrigin-RevId: 169476478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'+=' for lists now mutates the lhs list instead of creating a new one and assigning to lhs (https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#mutating).
This is a fix for https://ci.bazel.io/blue/organizations/jenkins/Global%2Frules_nodejs/detail/rules_nodejs/56/pipeline/