Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose node headers as a cc_library #3679

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Expose node headers as a cc_library #3679

merged 1 commit into from
Aug 11, 2023

Conversation

dzbarsky
Copy link
Contributor

@dzbarsky dzbarsky commented Aug 9, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alexeagle alexeagle merged commit 48494f0 into bazel-contrib:main Aug 11, 2023
alexeagle added a commit that referenced this pull request Aug 12, 2023
@alexeagle
fix(windows): unbreak CI with allow_empty
977d7df 
We had an in-flight collision between two PRs. #3679 added a cc_library, but Node.js doesn't ship the required headers on Windows, so it wouldn't work there.
#3621 disallows empty glob, which breaks because of the missing headers.
Just add the allow_empty here to make it green.
@alexeagle alexeagle mentioned this pull request Aug 12, 2023
Merged
alexeagle added a commit that referenced this pull request Aug 12, 2023
@alexeagle
fix(windows): unbreak CI with allow_empty (#3681)
f9ea4ac 
We had an in-flight collision between two PRs. #3679 added a cc_library, but Node.js doesn't ship the required headers on Windows, so it wouldn't work there.
#3621 disallows empty glob, which breaks because of the missing headers.
Just add the allow_empty here to make it green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@mattem mattem Awaiting requested review from mattem mattem is a code owner

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@jbedard jbedard Awaiting requested review from jbedard jbedard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @alexeagle