Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace protobufjs with protobufjs-cli in examples/protobufjs #3543

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

Katee
Copy link
Contributor

@Katee Katee commented Aug 30, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Unchanged.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I ran scripts/update_nested_lock_files.sh to create the updates in examples/protobufjs/yarn.lock.

@Katee Katee changed the title Use protobufjs-cli in examples/protobufjs refactor: replace protobufjs with protobufjs-cli in examples/protobufjs Aug 30, 2022
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fantastic cleanup, thank you!

@alexeagle alexeagle merged commit 863729d into bazel-contrib:stable Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants