Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating to rbe_preconfig #3541

Merged
merged 2 commits into from
Aug 25, 2022
Merged

migrating to rbe_preconfig #3541

merged 2 commits into from
Aug 25, 2022

Conversation

aranguyen
Copy link
Contributor

@aranguyen aranguyen commented Aug 25, 2022

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • [x ] CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently rules_nodejs uses the deprecated rbe_autoconfig that still has reference to @bazeltools_platforms:xxx. It was also linked with bazel_toolchains repo. The flag --incompatible_use_platforms_repo_for_constraints is flipped causing failures for rules_nodejs in downstream pipelines.

Issue Number: bazelbuild/continuous-integration#1404
#3537

What is the new behavior?

This pr updates to use the new rbe_preconfig and remove bazel_toolchains from rules_nodejs as there are no other usage for bazel_toolchains.

Does this PR introduce a breaking change?

  • Yes
  • [x ] No

@aranguyen aranguyen marked this pull request as ready for review August 25, 2022 14:21
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for rolling out this change across the ecosystem

@alexeagle alexeagle merged commit baed3f3 into bazel-contrib:stable Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants