Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove usage of managed_directories #3466

Merged
merged 2 commits into from
Jun 9, 2022
Merged

chore: remove usage of managed_directories #3466

merged 2 commits into from
Jun 9, 2022

Conversation

alexeagle
Copy link
Collaborator

We discouraged users from using this as of rnj 5.0, and now Bazel is removing the feature.

Fixes #3465

We discouraged users from using this as of rnj 5.0, and now Bazel is removing the feature.

Fixes #3465
Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@gregmagolan gregmagolan merged commit f96cfde into stable Jun 9, 2022
@alexeagle alexeagle deleted the mgd_dir branch August 10, 2022 21:45
gitlab-dfinity pushed a commit to dfinity/ic that referenced this pull request Jul 4, 2023
…'master'

[IDX-2620] Stop using managed_directories.

It is deleted in bazel 6 and using it is not required and not
recommended anymore for nodejs rules:
bazel-contrib/rules_nodejs#3466 

See merge request dfinity-lab/public/ic!13351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rules_nodejs CI is broken with Bazel@Head
2 participants