Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(concatjs): tsc-wrapped compilation workers are subject to linker race-conditions #3370

Merged
merged 1 commit into from
Mar 20, 2022
Merged

fix(concatjs): tsc-wrapped compilation workers are subject to linker race-conditions #3370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/concatjs/internal/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,11 @@ nodejs_binary(
"@npm//typescript",
],
entry_point = ":tsc_wrapped/tsc_wrapped.js",
# With RBE or --worker_sandboxing you'll see that when supports_workers=True it doesn't run_node
# so it doesn't have the linker. Still needs our custom patches on require()
templated_args = ["--bazel_patch_module_resolver"],
# Disables the Bazel node modules linker. The node module linker is unreliable for the
# persistent worker executable, as it would rely on the `node_modules/` folder in the
# execroot that can be shared in non-sandbox environments or for persistent workers.
# https://docs.bazel.build/versions/main/command-line-reference.html#flag--worker_sandboxing.
templated_args = ["--nobazel_run_linker"],
visibility = ["//visibility:public"],
)

Expand Down