test: update environment spec to work with windows #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the environment spec started failing on Windows. It was thought that this started happening with 4a025c0, but it turnes out that this failed many commits before but a Buildkite status just did not show up in the commit history (making it look like the PnP commit caused the failures).
devversion
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
devversion
force-pushed
the
env-spec-windows-fix
branch
from
c599858 to
4adda37
Compare
Looks like 78aefa3 updated the TypeScript docs file in the markdown directly, but not in the source code, causing CI to fail.
devversion
force-pushed
the
env-spec-windows-fix
branch
from
4adda37 to
7d0122a
Compare
|
I've also fixed the docs content test. Not sure why 78aefa3 changed the link. Seems like an invalid one as well. |
alexeagle
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the environment spec started failing on Windows. It was
thought that this started happening with 4a025c0,
but it turnes out that this failed many commits before but a Buildkite status
just did not show up in the commit history (making it look like the PnP commit
caused the failures).
Root-cause seems to be 7993296 which changed the
RUNFILESvariable.