Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jasmine): can not reference runner when exports_directories_only=… #3293

Merged
merged 2 commits into from
Jan 27, 2022
Merged

fix(jasmine): can not reference runner when exports_directories_only=… #3293

merged 2 commits into from
Jan 27, 2022

Conversation

thesayyn
Copy link
Collaborator

…True

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #3280

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@thesayyn thesayyn requested a review from mattem as a code owner January 26, 2022 18:54
alexeagle
alexeagle reviewed Jan 26, 2022
View reviewed changes
docs/Jasmine.md Show resolved Hide resolved
examples/nestjs/WORKSPACE Show resolved Hide resolved
internal/npm_install/generate_build_file.ts Outdated Show resolved Hide resolved
packages/jasmine/BUILD.bazel Outdated Show resolved Hide resolved
packages/jasmine/jasmine_node_test.bzl Outdated Show resolved Hide resolved
packages/jasmine/package.json Outdated Show resolved Hide resolved
alexeagle
alexeagle approved these changes Jan 27, 2022
View reviewed changes
examples/nestjs/WORKSPACE Show resolved Hide resolved
@thesayyn
Copy link
Collaborator Author

I will follow up with another PR to flip more examples/e2e targets.

@alexeagle alexeagle mentioned this pull request Jan 27, 2022
Closed
@alexeagle alexeagle merged commit 0be0eeb into stable Jan 27, 2022
@alexeagle alexeagle mentioned this pull request Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@mattem mattem Awaiting requested review from mattem mattem is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesayyn @alexeagle