refactor: set symlink_node_modules default to False in yarn_install and npm_install #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
requested review from
alan-agius4,
alexeagle,
jbedard,
mattem and
mrmeku
as code owners
gregmagolan
force-pushed
the
symlink_node_modules_default_to_false
branch
3 times, most recently
from
5540a78 to
4a070c7
Compare
gregmagolan
force-pushed
the
symlink_node_modules_default_to_false
branch
7 times, most recently
from
3ade688 to
d35ce7b
Compare
alexeagle
reviewed
Jan 11, 2022
| @@ -20,6 +17,7 @@ load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install") | |||
| yarn_install( | |||
| # Name this npm so that Bazel Label references look like @npm//package | |||
| name = "npm", | |||
| data = ["//:patches/jest-haste-map+26.6.2.patch"], | |||
There was a problem hiding this comment.
oops, we should have updated jest so this patch isn't needed, I'll TAL
There was a problem hiding this comment.
yea. will do in a follow-up across the repo
alexeagle
approved these changes
Jan 11, 2022
gregmagolan
force-pushed
the
symlink_node_modules_default_to_false
branch
from
d35ce7b to
7485180
Compare
devversion
added a commit
to devversion/dev-infra
that referenced
this pull request
Mar 2, 2022
As of RNJ v5, the node modules are no longer symlinked by default. Rather a new separate install is maintained inside Bazel. This was a little controversial in the past since it made debugging harder, and required more IO locally/or even downloads depending on how Yarn is cached/configured locally. With the current setup, symlinks are no longer enabled and we can remove the managed directory configuration. bazel-contrib/rules_nodejs#3214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds section to docs to explain why using
symlink_node_modulesis not recommended.