refactor: remove package_json attribute from node_repositories #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
remove_node_repositories_package_json
branch
2 times, most recently
from
1c5a36f to
7f0dfb0
Compare
gregmagolan
force-pushed
the
remove_node_repositories_package_json
branch
from
7f0dfb0 to
fde3f7c
Compare
alexeagle
approved these changes
Jan 11, 2022
| package_json = ["//:package.json"], | ||
| ) | ||
| # @nodejs_host//:yarn | ||
| node_repositories() |
There was a problem hiding this comment.
what's the point of this example now? I think this PR is dropping the "user managed deps" feature altogether?
There was a problem hiding this comment.
Not much point. Can deleted in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update all reference of
@nodejsrepository to its new name@nodejs_host