Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split ts_project.bzl #3208

Merged
merged 1 commit into from
Jan 10, 2022
Merged

refactor: split ts_project.bzl #3208

merged 1 commit into from
Jan 10, 2022

Conversation

alexeagle
Copy link
Collaborator

The macro is now in the public api file, and the validate_options rule is in its own file.
Introduce a 'lib' struct for code sharing. This matches our more recently preferred code layout.

The macro is now in the public api file, and the validate_options rule is in its own file.
Introduce a 'lib' struct for code sharing. This matches our more recently preferred code layout.
Copy link
Collaborator

@kormide kormide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like nothing has changed in the public-facing api, right?

@alexeagle
Copy link
Collaborator Author

right, this one is a pure refactoring. No changes in the generated docs, nor the integration tests or examples/e2e, so that demonstrates that users don't notice this one.

@alexeagle alexeagle merged commit a466d72 into 5.x Jan 10, 2022
@alexeagle alexeagle deleted the split_ts_project branch January 10, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants